Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use * instead of primary alias in count queries with CTE #3730

Closed
wants to merge 4 commits into from
Closed

Use * instead of primary alias in count queries with CTE #3730

wants to merge 4 commits into from

Conversation

christophstrobl
Copy link
Member

Still a draft - might be worth exploring if we can maybe avoid the mutable state in the count transformer that sets the CTE flag.

@mp911de mp911de self-assigned this Jan 13, 2025
@mp911de mp911de marked this pull request as ready for review January 13, 2025 09:48
@mp911de mp911de linked an issue Jan 13, 2025 that may be closed by this pull request
Generating countQuery for queries with CTE fails with actual pagination #3726
Closed
@mp911de mp911de changed the title Use * instead of primary alias in count queries with CTE Use * instead of primary alias in count queries with CTE Jan 13, 2025
@mp911de mp911de added the type: bug A general bug label Jan 13, 2025
@mp911de mp911de added this to the 3.4.2 (2024.1.2) milestone Jan 13, 2025
mp911de pushed a commit that referenced this pull request Jan 13, 2025
@christophstrobl @mp911de
Use * instead of primary alias in count queries with CTE.
643a3a9 
Closes #3726
Original pull request: #3730
mp911de added a commit that referenced this pull request Jan 13, 2025
@mp911de
Polishing.
f2d1a35 
Introduce QueryInformation to provide query introspection results. Refine generics.

See #3726
Original pull request: #3730
mp911de pushed a commit that referenced this pull request Jan 13, 2025
@christophstrobl @mp911de
Use * instead of primary alias in count queries with CTE.
b79f64d 
Closes #3726
Original pull request: #3730
@mp911de
Copy link
Member

mp911de commented Jan 13, 2025

That's merged, backported, and polished now.

@mp911de mp911de closed this Jan 13, 2025
@mp911de mp911de deleted the issue/3726 branch January 13, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: bug A general bug
Projects
None yet
Milestone
3.4.2 (2024.1.2)
Development

Successfully merging this pull request may close these issues.

Generating countQuery for queries with CTE fails with actual pagination
2 participants
@christophstrobl @mp911de